removed flake8 from .travis.yml#125
Merged
Merged
Conversation
georgeRobertson
commented
Aug 7, 2020
georgeRobertson
commented
Collaborator
- Please check if the Pull Request fulfills these requirements
- The commit message is clear and concise
- Test for the changes have been added and reviewed
- Documentation has been added to all new features and edited code has had documentation reviewed
- What kind of change does this Pull request introduce? (Bug fix, feature, docs update, ...)
- What is the current behaviour? (Link to a current open issue if possible)
- What is the new behaviour? (is this a feature change?)
- Does this Pull Request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 44 44
Lines 1480 1480
=======================================
Hits 1402 1402
Misses 78 78
Continue to review full report at Codecov.
|
murd0
approved these changes
Aug 7, 2020
murd0
left a comment
murd0
left a comment
Contributor
There was a problem hiding this comment.
This isn't actually a bug but necessitating flake8 passes is a bit draconian so we can just remove it from the ci/cd pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.